Bug 261899

Summary: Remove warnings in NativePromise when both log and release log are disabled.
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: Web Template FrameworkAssignee: Stephan Szabo <stephan.szabo>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Stephan Szabo 2023-09-21 12:02:58 PDT
At least on LLVM17, we get warnings for a few methods in NativePromise about unused arguments that are used in logging statements when both LOG_DISABLED and RELEASE_LOG_DISABLED are true. Putting in UNUSED_PARAMs similar to resolve seemed to work for us.
Comment 1 Stephan Szabo 2023-09-21 12:05:02 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18034
Comment 2 EWS 2023-09-22 10:17:09 PDT
Committed 268318@main (c24c48984502): <https://commits.webkit.org/268318@main>

Reviewed commits have been landed. Closing PR #18034 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-09-22 10:18:15 PDT
<rdar://problem/115900146>