Bug 26188 – Clarify some of the cases in the coding style guide

• Component: WebKit Website
• Status: RESOLVED FIXED

[Kenneth Rohde Christiansen]

Here is a patch clarifying some cases of ambiguity in the coding style guide, with regard to control clauses.

[Kenneth Rohde Christiansen]

Created attachment 30948 [details]
Changed the coding style document to clarify some cases of ambiguity.

[David Kilzer (:ddkilzer)]

Comment on attachment 30948 [details]
Changed the coding style document to clarify some cases of ambiguity.

You must set the review? flag to get it reviewed. :)

[David Levin]

Since you're clarifying this rule about single line clauses, you may want to make it slightly more general (as discussed on webkit-dev).

Here was my attempt but you may find a way to phrase it better:
     "Control clauses (including any preceeding comments) that are one physical line should not use braces".

Good:
if (test) {
   myFunction(reallyLongParam1, reallyLongParam2, ...
              reallyLongParam4);
}

[Kenneth Rohde Christiansen]

Created attachment 30955 [details]
Incorporated the review commetns

[David Kilzer (:ddkilzer)]

Comment on attachment 30955 [details]
Incorporated the review commetns

You must still set the review? flag.

[Kenneth Rohde Christiansen]

How do I do that? Add a keyword?

[David Kilzer (:ddkilzer)]

(In reply to comment #6)
> How do I do that? Add a keyword?

Click the "Edit" button on the attachment after it's been attached, or look for the "Flags" section when attaching new files and set the pop-up menu to "?" next to the word "review".

[David Kilzer (:ddkilzer)]

Comment on attachment 30955 [details]
Incorporated the review commetns

r=me.  I'll land this with some verbage tweaks.

[David Kilzer (:ddkilzer)]

$ git svn dcommit
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebKitSite/ChangeLog
        M       WebKitSite/coding/coding-style.html
Committed r44473

http://trac.webkit.org/changeset/44473

[David Kilzer (:ddkilzer)]

(In reply to comment #8)
> (From update of attachment 30955 [details] [review])
> r=me.  I'll land this with some verbage tweaks.

Also, verbiage tweaks. :)