Bug 261841
| Summary: | [Filters] Don't override the alpha channel of the GraphicsDropShadow color by the shadow opacity | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Layout and Rendering | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 261925 | ||
Said Abou-Hallawa
Creating the GraphicsDropShadow with color equal to
auto color = m_shadowColor.colorWithAlpha(m_shadowOpacity);
is wrong since it will override the alpha channel of the drop-shadow filter with the shadow opacity. For example an element with the following css
filter: drop-shadow(15px 15px 0px rgba(0, 0, 0, 0.5));
will display a black drop shadow effect for this element. This css filter appears in the expected test page: imported/w3c/web-platform-tests/css/filter-effects/css-filters-animation-drop-shadow-expected.html.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/115812347>
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/17997
EWS
Committed 268233@main (db985ec58914): <https://commits.webkit.org/268233@main>
Reviewed commits have been landed. Closing PR #17997 and removing active labels.