Summary: | [Chromium] Change scrollbar theme code to use different classes on Windows and Linux | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Langley <agl> | ||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Adam Langley
2009-06-03 15:20:21 PDT
Created attachment 30926 [details]
patch
Comment on attachment 30926 [details]
patch
spelling:
6 Windows and Linux rather than suppling symbols. The ScrollbarTheme
I think you meant supplying.
I know you're just moving, but we don't name arguments when the names don't add anything:
42 virtual void paintTrackPiece(GraphicsContext* gc, Scrollbar* scrollbar, const IntRect& rect, ScrollbarPart partType);
43 virtual void paintButton(GraphicsContext* gc, Scrollbar* scrollbar, const IntRect& rect, ScrollbarPart partType);
44 virtual void paintThumb(GraphicsContext* gc, Scrollbar* scrollbar, const IntRect& rect);
Looks sane to me. r+ you can fix the above nits when landing.
|