Bug 26174

Summary:

[Chromium] Change scrollbar theme code to use different classes on Windows and Linux

Product:

WebKit

Reporter:

Adam Langley <agl>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	eric: review+

Adam Langley

Reported 2009-06-03 15:20:21 PDT

Change Chromium scrollbar theme code to use different classes on Windows and Linux rather than suppling symbols. The ScrollbarTheme class is already using virtual dispatch, so there's no reason not to. This should not affect any layout tests.

Attachments
patch (21.74 KB, patch) 2009-06-03 15:21 PDT, Adam Langley	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Langley

Comment 1 2009-06-03 15:21:02 PDT

Created attachment 30926 [details] patch

Eric Seidel (no email)

Comment 2 2009-06-03 15:32:48 PDT

Comment on attachment 30926 [details] patch spelling: 6 Windows and Linux rather than suppling symbols. The ScrollbarTheme I think you meant supplying. I know you're just moving, but we don't name arguments when the names don't add anything: 42 virtual void paintTrackPiece(GraphicsContext* gc, Scrollbar* scrollbar, const IntRect& rect, ScrollbarPart partType); 43 virtual void paintButton(GraphicsContext* gc, Scrollbar* scrollbar, const IntRect& rect, ScrollbarPart partType); 44 virtual void paintThumb(GraphicsContext* gc, Scrollbar* scrollbar, const IntRect& rect); Looks sane to me. r+ you can fix the above nits when landing.

Note You need to log in before you can comment on or make changes to this bug.