Bug 261428

Summary: AX ITM: Not necessary to cache IsFocused in isolated objects.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Andres Gonzalez
Reported 2023-09-11 14:03:00 PDT
.
Attachments
Patch (7.69 KB, patch)
2023-09-11 14:08 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (7.74 KB, patch)
2023-09-12 05:50 PDT, Andres Gonzalez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-09-11 14:03:11 PDT
<rdar://problem/115312448>
Andres Gonzalez
Comment 2 2023-09-11 14:08:29 PDT
Created attachment 467647 [details] Patch
Tyler Wilcock
Comment 3 2023-09-11 16:16:18 PDT
Comment on attachment 467647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467647&action=review > COMMIT_MESSAGE:7 > +Instead of caching this property and updating it, this patch changes the implementation of AXIsolatedObject::isFocused() to use the tree's focused object ID. this guaranties consistency between the methods isFocuse() and focusedUIElement, i.e., isFocused() will return true if and only if the object is the unique focus. > this guaranties this should probably be capitalized, and guaranties looks like a typo. isFocuse() is another likely typo.
Andres Gonzalez
Comment 4 2023-09-12 05:50:10 PDT
Created attachment 467658 [details] Patch
EWS
Comment 5 2023-09-12 07:30:15 PDT
Committed 267901@main (435613e4bde1): <https://commits.webkit.org/267901@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467658 [details].
Note You need to log in before you can comment on or make changes to this bug.