Bug 261406
| Summary: | GraphicsContext::createImageBuffer should not create ImageBuffers that are backed by display lists | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> |
| Component: | Canvas | Assignee: | Kimmo Kinnunen <kkinnunen> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dino, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Kimmo Kinnunen
GraphicsContext::createImageBuffer should not create ImageBuffers that are backed by display lists
The calling code which creates ImageBuffers is never agnostic to whether the created buffer is backed by a display list or not.
If the calling code intends to use the display list as display list, it needs to access the list. This is done by creating DisplayList::Recorder explicitly.
Even if the target GraphicsContext would be a DisplayList::Recorder, creating a new image buffer as a display list and drawing that to the target would end up resulting a bitmap drawn to the target.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/115283169>
Kimmo Kinnunen
Pull request: https://github.com/WebKit/WebKit/pull/17649
EWS
Committed 268193@main (afbd4f014569): <https://commits.webkit.org/268193@main>
Reviewed commits have been landed. Closing PR #17649 and removing active labels.