Bug 261266
Summary: | WebRTC maintain-framerate degradationPreference does not apply to resolution adaptation | ||
---|---|---|---|
Product: | WebKit | Reporter: | coin_st |
Component: | WebRTC | Assignee: | youenn fablet <youennf> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | coin_st, kagh, karlcow, maojie0924, webkit-bug-importer, youennf |
Priority: | P2 | Keywords: | BrowserCompat, InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=267577 |
coin_st
By configuring video sender's degradationPreference as maintain-framerate according to standard (https://www.w3.org/TR/mst-content-hint/#degradation-preference-when-encoding), resolution adaptation is expected to be adaptive when certain limitation reasons are satisfied such as lack of compute resources or bandwidth. But safari does not work with this setting under any circumstance even at the beginning, sending resolution usually starts with lower dimensions then ramps up to the target resolution, chromium and firefox both work and we can observe this behavior under maintain-framerate.
We set degradationPreference by following code snippet:
s = pc.getSenders()[1];
p = s.getParameters();
p.degradationPreference = "maintain-framerate";
s.setParameters(p);
Chromium and firefox will have distinct resolution adaptation at beginning and you may check getStats() outbound qualityLimitationReason which should be "bandwidth" and slow resolution ramp up can be observed, but nothing would happen on safari, plus seems qualityLimitationReason is not supported by safari.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/115481961>
youenn fablet
Pull request: https://github.com/WebKit/WebKit/pull/18155
EWS
Committed 268443@main (8bfbdfcad876): <https://commits.webkit.org/268443@main>
Reviewed commits have been landed. Closing PR #18155 and removing active labels.
coin_st
(In reply to youenn fablet from comment #2)
> Pull request: https://github.com/WebKit/WebKit/pull/18155
Hi Youenn, do you know what target release that will have this fix?
youenn fablet
Follow-up fix needed at https://bugs.webkit.org/show_bug.cgi?id=267577.
Kaustav
@youenn we have tested from our end and it works now. Thanks