Summary: | Refactor methods of WorkerMessagingProxy used to talk to main-thread loader into new interface. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dmitry Titov <dimich> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, jianli, levin | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Dmitry Titov
2009-06-01 18:15:33 PDT
Created attachment 30850 [details]
Proposed patch
Comment on attachment 30850 [details] Proposed patch A few issues to fix up, so r- for this version of the patch. > diff --git a/WebCore/WebCore.xcodeproj/project.pbxproj b/WebCore/WebCore.xcodeproj/project.pbxproj > index a2742ac..2996d35 100644 > --- a/WebCore/WebCore.xcodeproj/project.pbxproj > +++ b/WebCore/WebCore.xcodeproj/project.pbxproj > @@ -208,6 +208,7 @@ > 188604B30F2E654A000B6443 /* DOMTimer.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 188604B10F2E654A000B6443 /* DOMTimer.cpp */; }; > 188604B40F2E654A000B6443 /* DOMTimer.h in Headers */ = {isa = PBXBuildFile; fileRef = 188604B20F2E654A000B6443 /* DOMTimer.h */; }; > + 18F831B80FD48C7800D8C56B /* WorkerLoaderProxy.h in Headers */ = {isa = PBXBuildFile; fileRef = 18F831B70FD48C7800D8C56B /* WorkerLoaderProxy.h */; }; Is this out of order? > diff --git a/WebCore/loader/WorkerThreadableLoader.cpp b/WebCore/loader/WorkerThreadableLoader.cpp > Is it possible to remove the #include "WorkerMessagingProxy.h"? > -WorkerThreadableLoader::MainThreadBridge::MainThreadBridge(PassRefPtr<ThreadableLoaderClientWrapper> workerClientWrapper, WorkerMessagingProxy& messagingProxy, const String& taskMode, > +WorkerThreadableLoader::MainThreadBridge::MainThreadBridge(PassRefPtr<ThreadableLoaderClientWrapper> workerClientWrapper, WorkerLoaderProxy* loaderProxy, const String& taskMode, Ideally loaderProxy would be a & since it can never be 0. > diff --git a/WebCore/workers/WorkerLoaderProxy.h b/WebCore/workers/WorkerLoaderProxy.h > + > + virtual ~WorkerLoaderProxy() {} Nice to have a space in { }. > + // Postst callbacks from loading code to the WorkerContext. The 'mode' is used to differentiate Postst spelling. (In reply to comment #2) > (From update of attachment 30850 [details] [review]) > > + 18F831B80FD48C7800D8C56B /* WorkerLoaderProxy.h in Headers */ = {isa = PBXBuildFile; fileRef = 18F831B70FD48C7800D8C56B /* WorkerLoaderProxy.h */; }; > > Is this out of order? Seems ok in the xcode itself (the file is in right alphabetical order in the Sources). > > diff --git a/WebCore/loader/WorkerThreadableLoader.cpp b/WebCore/loader/WorkerThreadableLoader.cpp > Is it possible to remove the #include "WorkerMessagingProxy.h"? Yes, removed. Instead, included WorkerLoaderProxy.h > > +WorkerThreadableLoader::MainThreadBridge::MainThreadBridge(PassRefPtr<ThreadableLoaderClientWrapper> workerClientWrapper, WorkerLoaderProxy* loaderProxy, const String& taskMode, > > Ideally loaderProxy would be a & since it can never be 0. Done, also changed WorkerThread::workerLoaderProxy and WorkerThread::workerObjectProxy to return &, accordingly. > > diff --git a/WebCore/workers/WorkerLoaderProxy.h b/WebCore/workers/WorkerLoaderProxy.h > > + > > + virtual ~WorkerLoaderProxy() {} > Nice to have a space in { }. Done. > > + // Postst callbacks from loading code to the WorkerContext. The 'mode' is used to differentiate > > Postst spelling. Fixed. Created attachment 31077 [details]
Updated according to review comments.
|