Bug 261080

Summary: WorkQueue should inherit from ConcurrentWorkQueue
Product: WebKit Reporter: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Component: Web Template FrameworkAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status: NEW    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=260779

Jean-Yves Avenard [:jya]
Reported 2023-09-03 04:03:08 PDT
There are currently multiple issues that needs to be resoved: - A WorkQueue is a ConcurrentWorkQueue - A ConcurrentWorkQueue may be a serial workqueue - A WorkQueue must be a SerialFunctionDispatcher to be able to use it interchangeably with other thread-like object (like a RunLoop or a WorkerThread) - IOCache class can use either a WorkQueue or a ConcurrentWorkQueue and as such they have to be related, currently it is using the WorkQueueBase class which is a bad thing. (WorkQueueBase should be a private inheritance) It is essential that we can distinguish a serial WorkQueue from a concurrent one. One issue is that the class name ConcurrentWorkQueue seems to indicate that it is only a concurrent queue (even though it may behave just like a serial WorkQueue (and this is the default implementation on non cocoa platform). A rename to something more helpful would be useful. Maybe `WorkDispatcher` ? We handle the WorkQueue inheriting from a SerialFunctionDispatch in bug 260779. While this code change should be straightforward, there are linkage issues due to WebKit only exporting some symbols from a class and this is conflicting with the vtables used for the multiple inheritance.
Attachments
Radar WebKit Bug Importer
Comment 1 2023-09-03 04:03:28 PDT
Note You need to log in before you can comment on or make changes to this bug.