Bug 261030

Summary:

[IFC][line-clamp] Add support for "more info" type of trailing link handling

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

274308

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-

alan

Reported 2023-09-01 06:06:15 PDT

ssia

Attachments
Patch (18.96 KB, patch) 2023-09-01 06:07 PDT, alan	no flags	Details Formatted Diff Diff
Patch (27.45 KB, patch) 2023-09-01 13:41 PDT, alan	no flags	Details Formatted Diff Diff
Patch (31.00 KB, patch) 2023-09-01 15:39 PDT, alan	no flags	Details Formatted Diff Diff
Patch (33.96 KB, patch) 2023-09-01 17:22 PDT, alan	no flags	Details Formatted Diff Diff
Patch (34.14 KB, patch) 2023-09-02 12:16 PDT, alan	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2023-09-01 06:07:47 PDT

Created attachment 467516 [details] Patch

alan

Comment 2 2023-09-01 13:41:02 PDT

Created attachment 467518 [details] Patch

alan

Comment 3 2023-09-01 15:39:00 PDT

Created attachment 467520 [details] Patch

alan

Comment 4 2023-09-01 17:22:21 PDT

Created attachment 467521 [details] Patch

Antti Koivisto

Comment 5 2023-09-02 08:13:09 PDT

Comment on attachment 467521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467521&action=review > Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp:414 > + // This is link-box type of line clamping where we check if the inline content ends in a link > + // and move such link content next to the clamped line's trailing ellispsis. > + // > + // first line > + // second line is clamped... more info > + // > + // where "more info" is a link and it comes from the end of the inline content (normally invisible due to block direction clamping) > + // This is only to match legacy line clamping behavior (and not a block-ellispsis: <string> implementation) > + // It supports horizontal, left-to-right content only where the link inline box has (non-split) text content and when > + // the link content ('more info') fits the clamped line. It would be nice to give some background about what this is for and why this is still needed (and also that it is triggered by -webkit-line-clamp).

alan

Comment 6 2023-09-02 12:16:19 PDT

Created attachment 467527 [details] Patch

EWS

Comment 7 2023-09-02 13:42:38 PDT

Committed 267588@main (bf48ac60d4bb): <https://commits.webkit.org/267588@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467527 [details].

Radar WebKit Bug Importer

Comment 8 2023-09-02 13:43:16 PDT

<rdar://problem/114878221>

Note You need to log in before you can comment on or make changes to this bug.