Bug 261025

Summary:	Allow using longer ancestor chains in StyleCustomPropertyData
Product:	WebKit	Reporter:	Antti Koivisto <koivisto>
Component:	CSS	Assignee:	Antti Koivisto <koivisto>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Antti Koivisto

Reported 2023-09-01 04:18:27 PDT

Currently only one ancestor is allowed. It is typical to have many properties defined on :root. If we more definition further down into the tree in multiple levels then all those properties get copied and we can get large maps duplicated to many elements. This also makes equality comparisons slow.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-09-01 04:18:42 PDT

<rdar://problem/114815380>

Antti Koivisto

Comment 2 2023-09-01 04:30:19 PDT

Pull request: https://github.com/WebKit/WebKit/pull/17338

EWS

Comment 3 2023-09-03 10:01:32 PDT

Committed 267595@main (8b7bc22a8c87): <https://commits.webkit.org/267595@main> Reviewed commits have been landed. Closing PR #17338 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.