Bug 260776

Summary: [IFC] Use opaque InlineItem to compute out-of-flow static position
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

alan
Reported 2023-08-27 09:52:13 PDT
ssia
Attachments
Patch (45.49 KB, patch)
2023-08-27 09:57 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (48.92 KB, patch)
2023-08-27 19:25 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (34.52 KB, patch)
2023-08-28 12:37 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (36.91 KB, patch)
2023-08-28 15:14 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (36.97 KB, patch)
2023-08-28 15:49 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (39.60 KB, patch)
2023-08-28 19:36 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (39.57 KB, patch)
2023-08-28 20:34 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (38.93 KB, patch)
2023-08-29 07:20 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (41.12 KB, patch)
2023-08-30 07:31 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2023-08-27 09:57:32 PDT
Created attachment 467454 [details] Patch
alan
Comment 2 2023-08-27 19:25:29 PDT
Created attachment 467455 [details] Patch
alan
Comment 3 2023-08-28 12:37:39 PDT
Created attachment 467468 [details] Patch
alan
Comment 4 2023-08-28 15:14:34 PDT
Created attachment 467470 [details] Patch
alan
Comment 5 2023-08-28 15:49:23 PDT
Created attachment 467472 [details] Patch
alan
Comment 6 2023-08-28 19:36:25 PDT
Created attachment 467476 [details] Patch
alan
Comment 7 2023-08-28 20:34:26 PDT
Created attachment 467478 [details] Patch
Antti Koivisto
Comment 8 2023-08-28 22:54:27 PDT
Comment on attachment 467478 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467478&action=review > COMMIT_MESSAGE:6 > +Let's replace existing out-of-flow handling with using opaque inline items instead. Nice! > Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:884 > + auto formattingContext = this->formattingContext(); Does this purposefully create a copy of the formatting context?
alan
Comment 9 2023-08-29 07:14:26 PDT
(In reply to Antti Koivisto from comment #8) > Comment on attachment 467478 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=467478&action=review > > > COMMIT_MESSAGE:6 > > +Let's replace existing out-of-flow handling with using opaque inline items instead. > > Nice! > > > Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:884 > > + auto formattingContext = this->formattingContext(); > > Does this purposefully create a copy of the formatting context? certainly not! good catch!
alan
Comment 10 2023-08-29 07:20:33 PDT
Created attachment 467481 [details] Patch
alan
Comment 11 2023-08-30 07:31:05 PDT
Created attachment 467491 [details] Patch
EWS
Comment 12 2023-08-30 09:29:17 PDT
Committed 267456@main (bac664c02d19): <https://commits.webkit.org/267456@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467491 [details].
Radar WebKit Bug Importer
Comment 13 2023-08-30 09:30:17 PDT
<rdar://problem/114705938>
Note You need to log in before you can comment on or make changes to this bug.