Bug 260708
| Summary: | Remove Quirk shouldAvoidUsingIOS13ForGmail for mail.google.com | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | New Bugs | Assignee: | Karl Dubost <karlcow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | GoodFirstBug, InRadar |
| Version: | Safari 17 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://mail.google.com | ||
| Bug Depends on: | 200605 | ||
| Bug Blocks: | |||
Karl Dubost
This Quirk was added with Bug 200605 on August 2019 (4 years ago)
tracked also at rdar://problem/52545742
Steps to understand if it can be removed
1. With Safari on an iPhone
2. Go to https://mail.google.com/
3. Login
4. Connect to the phone with Web Inspector on a MacBook
5. Inspect the mail.google.com tab from the iPhone
6. check the User Agent String in the console with `navigator.userAgent`
7. It should be "Mozilla/5.0 (iPhone; CPU iPhone OS 12_1_3 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko)" because of the Quirk
8. Disable Site Specific Hacks on the phone
9. Reload the site
10. Check the User Agent String in the console with `navigator.userAgent`
11. It should be something along "Mozilla/5.0 (iPhone; CPU iPhone OS 16_6 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.6 Mobile/15E148 Safari/604.1"
12. Double check that all images are loaded.
13. Change the User Agent to be "Mozilla/5.0 (iPhone; CPU iPhone OS 13 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13 Mobile/15E148 Safari/604.1"
14. Reload the page
Expected
All images are being loaded.
If images are properly loaded we can remove the Quirk.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/114438822>
Karl Dubost
See https://github.com/WebKit/WebKit/commit/b49d99266d0d84c0331d69f63263f5a856a5e773
or https://searchfox.org/wubkat/search?q=shouldAvoidUsingIOS13ForGmail&path=&case=false®exp=false
Karl Dubost
This Quirk can be removed now as iOS 13 has long passed.
Karl Dubost
Pull request: https://github.com/WebKit/WebKit/pull/32504
EWS
Committed 282652@main (eab1695be721): <https://commits.webkit.org/282652@main>
Reviewed commits have been landed. Closing PR #32504 and removing active labels.