Summary: | [SKIA] Crash when filling an empty pattern | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean McNamee <deanm> | ||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, skylined | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Dean McNamee
2009-05-28 06:08:25 PDT
Created attachment 30735 [details]
patch
Comment on attachment 30735 [details]
patch
The patch looks fine.
I would have used a named constant for the color. I'm surprised that skia doesn't have a "transparent" constant that you can return instead of having to manually construct a color.
Color::transparent is identical, and is guaranteed to be the right format due to COMPILE_ASSERT checks in ColorSkia.cpp.
Tab indent should be 4 spaces, not 2.
Those are both nits someone could fix when landing.
Created attachment 31129 [details]
Patch with indention fixed
Fixed the indention line. I don't think making a constant (since Skia doesn't already have one) is worthwhile, it's pretty clear from the comment that I'm creating a transparent color. I don't like using Color in place of SkColor, even though I realize they have the same layout.
|