Bug 26061 – [SKIA] Crash when filling an empty pattern

• Component: DOM
• Status: RESOLVED FIXED

[Dean McNamee]

Skia-specific crash, where we assume that the bitmap for a pattern is valid.  In reality it can return NULL.  For example:

createPattern(new Image, "repeat")

Original Chromium bug:

http://code.google.com/p/chromium/issues/detail?id=10881

[Dean McNamee]

Created attachment 30735 [details]
patch

[Eric Seidel (no email)]

Comment on attachment 30735 [details]
patch

The patch looks fine.

I would have used a named constant for the color.  I'm surprised that skia doesn't have a "transparent" constant that you can return instead of having to manually construct a color.

Color::transparent is identical, and is guaranteed to be the right format due to COMPILE_ASSERT checks in ColorSkia.cpp.

Tab indent should be 4 spaces, not 2.

Those are both nits someone could fix when landing.

[Dean McNamee]

Created attachment 31129 [details]
Patch with indention fixed

Fixed the indention line.  I don't think making a constant (since Skia doesn't already have one) is worthwhile, it's pretty clear from the comment that I'm creating a transparent color.  I don't like using Color in place of SkColor, even though I realize they have the same layout.

[Brent Fulgham]

Please don't remove "Reviewed by (OOPS)" comment created by prepare-ChangeLog.

Confirmed p-1.txt and p-2.txt differed only by spacing per Eric's comment and landed.

Landed in @r44575.