Bug 260531
| Summary: | [css-grid] css-grid/subgrid/subgrid-no-items-on-edges-001.html failing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sammy Gill <sgill26> |
| Component: | Layout and Rendering | Assignee: | Sammy Gill <sgill26> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 260533 | ||
Sammy Gill
css-grid/subgrid/subgrid-no-items-on-edges-001.html is currently failing on WPT
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/114271839>
Sammy Gill
Pull request: https://github.com/WebKit/WebKit/pull/17456
Sammy Gill
This patch is not quite ready yet. I think there is a simpler way of going about this so I'm going to attempt a new approach that will be much less convoluted.
The basis idea will be that we already recurse into a nested subgrid with the additional call to accumulateIntrinsicSizesForTrack so we can perhaps just store some extra information as new arguments that the nested margin, border, and padding will accumulate into
EWS
Committed 268947@main (ebd030f9b866): <https://commits.webkit.org/268947@main>
Reviewed commits have been landed. Closing PR #17456 and removing active labels.