Bug 26043

Summary: Patch to use some Windows specific files when building on windows
Product: WebKit Reporter: Fridrich Strba <fridrich.strba>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 2000   
Attachments:
Description Flags
Use the files for win32 build and package them
none
a new patch incorporating jan's suggestions
gustavo: review+
one more iteration none

Fridrich Strba
Reported 2009-05-27 05:28:39 PDT
The files in the GNUmakefile.am are present in the svn tree. Use them when building on windows and also package them in the tarball
Attachments
Use the files for win32 build and package them (2.59 KB, patch)
2009-05-27 05:29 PDT, Fridrich Strba 		no flags
DetailsFormatted DiffDiff
a new patch incorporating jan's suggestions (2.52 KB, patch)
2009-05-27 05:51 PDT, Fridrich Strba 		gustavo: review+
DetailsFormatted DiffDiff
one more iteration (2.48 KB, patch)
2009-05-27 06:06 PDT, Fridrich Strba 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fridrich Strba
Comment 1 2009-05-27 05:29:19 PDT
Created attachment 30703 [details] Use the files for win32 build and package them
Fridrich Strba
Comment 2 2009-05-27 05:51:47 PDT
Created attachment 30704 [details] a new patch incorporating jan's suggestions
Fridrich Strba
Comment 3 2009-05-27 06:06:46 PDT
Created attachment 30706 [details] one more iteration
Gustavo Noronha (kov)
Comment 4 2009-05-27 06:17:55 PDT
Comment on attachment 30704 [details] a new patch incorporating jan's suggestions This patch looks good. We tried to find out if automake supported elif, but it seem it does not, so we're sticking with this solution.
Gustavo Noronha (kov)
Comment 5 2009-05-27 07:03:22 PDT
Landed as r44188.
Maciej Stachowiak
Comment 6 2009-05-28 02:37:08 PDT
Comment on attachment 30706 [details] one more iteration Unflagging since this was apparently committed.
Maciej Stachowiak
Comment 7 2009-05-28 02:40:35 PDT
Comment on attachment 30706 [details] one more iteration Unflagging since this was apparently committed.
Maciej Stachowiak
Comment 8 2009-05-28 02:40:40 PDT
Comment on attachment 30706 [details] one more iteration Unflagging since this was apparently committed.
Note You need to log in before you can comment on or make changes to this bug.