Bug 26032

Summary: Chromium needs a frameless loader for workers
Product: WebKit Reporter: David Levin <levin>
Component: PlatformAssignee: David Levin <levin>
Status: RESOLVED INVALID    
Severity: Normal CC: ap, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed fix. none

David Levin
Reported 2009-05-26 15:09:07 PDT
Since chromium loads workers in a separate process from the frame, it needs a loader which doesn't rely on frames in order to do the loading. (This won't allow loaders to be used on other threads and is only needed for the chromium port.)
Attachments
Proposed fix. (45.31 KB, patch)
2009-05-27 15:48 PDT, David Levin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2009-05-27 15:48:08 PDT
Created attachment 30718 [details] Proposed fix. Although these is no chromium specific code, it is a chromium specific directory for two reasons: 1. I expect that only chromium will use it. 2. It is so similar to ResourceLoader/SubresourceLoader that to land it in the main directory those classes should be refactored but I haven't been able to figure out how to do that without adding many more virtual function calls and more complexity to those classes (which is badness).
Darin Fisher (:fishd, Google)
Comment 2 2009-05-27 16:48:26 PDT
Hmm... duplication of complicated code vs. making complicated code more complex ;-) How bad would the refactoring be? It seems like that is the better long term solution.
David Levin
Comment 3 2009-05-27 23:11:59 PDT
Comment on attachment 30718 [details] Proposed fix. Withdrawing for now... Will consider a dummy frame instead.
Note You need to log in before you can comment on or make changes to this bug.