Bug 260318
| Summary: | [css-break] 'orphans' and 'widows' property should have '2' as initial value | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | fantasai.bugs, mmaxfield, ntim, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through failing WPT test, came across following two failing where we don't have initial value for 'orphans' and 'windows' and return 'auto' instead of '2' as per spec.
Failing WPT Test: https://wpt.fyi/results/css/css-break/inheritance.html?label=master&label=experimental&aligned=&q=inheritance
sub-test names: Property orphans has initial value 2 & Property widows has initial value 2
Web-Spec: https://drafts.csswg.org/css-break/#property-index
I tried to look into CSSProperties.json whether we have way to do 'initial value' similar to Chromium bug couldn't figure out.
Just wanted to raise so we can fix it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tim Nguyen (:ntim)
removing all code related to `hasAutoOrphans` and `hasAutoWidows` should just work:
https://searchfox.org/wubkat/search?q=hasAutoOrphans&path=&case=false®exp=false
https://searchfox.org/wubkat/search?q=hasAutoWidows&path=&case=false®exp=false
(although some of these checks will need to be replaced with `style().orphans() == RenderStyle::initialOrphans()` or something similar)
Radar WebKit Bug Importer
<rdar://problem/114350539>
Ahmad Saleem
Test Changes (if we started doing it in future) - https://github.com/chromium/chromium/commit/b25fd3116d7cb9366a24af711666fc63a27f91b4
Tim Nguyen (:ntim)
*** This bug has been marked as a duplicate of bug 277559 ***