Bug 26028

Summary:

[Chromium] Chromium Linux leaves unpainted areas on very small scrollbars.

Product:

WebKit

Reporter:

Adam Langley <agl>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
patch	none
patch	eric: review+

Description Adam Langley 2009-05-26 14:10:36 PDT

The current code was assuming that we'll be painting buttons on the scrollbar
which isn't true on Linux. To reproduce, resize a page will scrollbars until
they are less than two widths high.

This will need pixel test baselines to be updated in the Chromium tree.

Comment 1 Adam Langley 2009-05-26 14:11:22 PDT

Created attachment 30680 [details]
patch

Comment 2 Adam Langley 2009-05-26 14:21:06 PDT

Created attachment 30681 [details]
patch

(Forgot bug links in the ChangeLog)

Comment 3 Eric Seidel (no email) 2009-06-02 15:37:46 PDT

Comment on attachment 30681 [details]
patch

The change is fine.  Please comment the code a bit more to explain what it's doing. I found:

int thickness =

a little strange until you explained to me that all scrollbar buttons are square.

Likewise it would be nice to explain why Chromium linux is different from Chromium Win here.

I don't need to see this again.  I trust you can come up with some nice comments to document this whenlanding.  Thanks!