Bug 26028

Summary: [Chromium] Chromium Linux leaves unpainted areas on very small scrollbars.
Product: WebKit Reporter: Adam Langley <agl>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
patch
none
patch eric: review+

Adam Langley
Reported 2009-05-26 14:10:36 PDT
The current code was assuming that we'll be painting buttons on the scrollbar which isn't true on Linux. To reproduce, resize a page will scrollbars until they are less than two widths high. This will need pixel test baselines to be updated in the Chromium tree.
Attachments
patch (4.47 KB, patch)
2009-05-26 14:11 PDT, Adam Langley 		no flags
DetailsFormatted DiffDiff
patch (4.56 KB, patch)
2009-05-26 14:21 PDT, Adam Langley 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Langley
Comment 1 2009-05-26 14:11:22 PDT
Created attachment 30680 [details] patch
Adam Langley
Comment 2 2009-05-26 14:21:06 PDT
Created attachment 30681 [details] patch (Forgot bug links in the ChangeLog)
Eric Seidel (no email)
Comment 3 2009-06-02 15:37:46 PDT
Comment on attachment 30681 [details] patch The change is fine. Please comment the code a bit more to explain what it's doing. I found: int thickness = a little strange until you explained to me that all scrollbar buttons are square. Likewise it would be nice to explain why Chromium linux is different from Chromium Win here. I don't need to see this again. I trust you can come up with some nice comments to document this whenlanding. Thanks!
Note You need to log in before you can comment on or make changes to this bug.