Bug 26011

Summary:

Fix flaky origin-follows-lexical-scope test

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

abarth, mjs, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none

Description Adam Barth 2009-05-25 11:35:16 PDT

I added a test last night that appears to be flaky.  I don't really understand why it's flaky, but here's an attempt to fix it.

Comment 1 Adam Barth 2009-05-25 11:39:18 PDT

Created attachment 30655 [details]
patch

Comment 2 Adam Barth 2009-05-25 14:56:04 PDT

Comment on attachment 30655 [details]
patch

This patch didn't seem to fix the problem...  :(

Comment 3 Adam Barth 2009-05-26 07:37:29 PDT

I'm not sure what to do about this test.  I can't reproduce the issue locally, which makes it hard to debug.  Options in include:

1) Disabling / deleting the test and losing its coverage.
2) Debugging it by checking in diagnostics / attempted fixes late at night.

Comment 4 Mark Rowe (bdash) 2009-05-26 11:41:18 PDT

We need to do something about it.  We can't leave it failing on the buildbot for days at a time.

Comment 5 Sam Weinig 2009-05-26 13:51:16 PDT

Please disable it for now.  It is much more helpful for the bot to be green.

Comment 6 Adam Barth 2009-05-26 14:19:42 PDT

(In reply to comment #5)
> Please disable it for now.  It is much more helpful for the bot to be green.

Disabled in r44159.