Summary: | REGRESSION (r42334): Unnecessary scroll bars remain after the document shrinks | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||||
Component: | Frames | Assignee: | Dave Hyatt <hyatt> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | hyatt | ||||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
mitz
2009-05-22 14:48:41 PDT
Created attachment 30603 [details]
Test case
Created attachment 30670 [details]
Patch
Comment on attachment 30670 [details] Patch > + Added two tests in fast/dynamic. It's better to give the names of the tests. > -- (void)_boundsChanged > +- (void)_boundsChangedToNewSize:(NSSize)size I think _boundsChangedTo: would be fine here rather than _boundsChangedToNewSize:. > - if (!NSEqualSizes(_private->lastLayoutSize, [self bounds].size)) { > + if (!NSEqualSizes(_private->lastLayoutSize, size)) { Indented one extra space here. > - frame->view()->resize([self bounds].size.width, [self bounds].size.height); > + frame->view()->resize(size.width, size.height); How about just resize(IntSize(size)) here instead? Has to be an explicit conversion because it's a conversion from floating point to integer, but nice to leave it as an object instead of breaking up into width/height. > +- (void)setFrameSize:(NSSize)size > +{ > + [self _boundsChangedToNewSize:size]; > + [super setFrameSize:size]; > +} I'm not sure we need a separate _boundsChangedToNewSize: method. I'd just put that code into the setFrameSize: override and not have a separate method. r=me Comment on attachment 30670 [details]
Patch
Breaks mail. clearing flag.
Comment on attachment 30670 [details]
Patch
Putting back darin's r+, since the bug in Mail is there in TOT and is not caused by this patch.
|