Bug 259635
Summary: | results.webkit.org shows only the result of either wincairo-release-tests-01 or -02 | ||
---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW | ||
Severity: | Normal | CC: | jbedard |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=270942 |
Fujii Hironori
We have two running WinCairo release tester workers, wincairo-release-tests-01 and wincairo-release-tests-02.
But, results.webkit.org shows only the result of wincairo-release-tests-02.
If I try reloading repeatedly, it occasionally shows only wincairo-release-tests-01.
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Finspector%2Fnetwork%2Fresource-timing.html&platform=wincairo
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Fujii Hironori
This is no longer reprodusible because WinCairo-64-bit-Release-Tests builder has only wincairo-release-tests-01 now.
However, the fundamental problem is still there.
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Finspector%2Fnetwork%2Fresource-timing.html&platform=GTK&version_name=Xvfb&style=release
shows the result of either gtk-linux-bot-18 or gtk-linux-bot-19 randomly.
Fujii Hironori
<https://results.webkit.org/api/results/layout-tests/fast/url/anchor.html?platform=win&style=release&limit=1> returns the following 2 configurations.
> "configuration":{
> "architecture":"x86_64",
> "flavor":"wk2",
> "is_simulator":false,
> "platform":"win",
> "style":"release",
> "version":10020348,
> "version_name":"Win10"
> },
> "configuration":{
> "architecture":"x86_64",
> "flavor":"wk2",
> "is_simulator":false,
> "platform":"win",
> "style":"release",
> "version":10017763,
> "version_name":"Win10"
> },
They have different 'version', same 'version_name', and no 'sdk'.
https://github.com/WebKit/WebKit/blob/b3f73e9dae0abe7aa017fe8ef7ca36f4cd5ac455/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/dashboard.js#L297
> results[strippedConfig.toKey()].splice(index, 0, [config, result]);
strippedConfig.toKey() is used as a key.
https://github.com/WebKit/WebKit/blob/b3f73e9dae0abe7aa017fe8ef7ca36f4cd5ac455/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/configuration.js#L188-L189
> if (this.version != null && (this.version_name == null || this.sdk != null))
> result += ' ' + Configuration.integerToVersion(this.version);
Configuration.toKey doesn't take 'version' into account in this case.
Fujii Hironori
bug#270942 changed the code.
Fujii Hironori
https://webkit.slack.com/archives/CU64U6FDW/p1732857177394669