Bug 259613
| Summary: | [GTK] Color chooser opens in a dialog outside the window | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | two |
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | PC | ||
| OS: | Linux | ||
two
this is not reproducible in MiniBrowser because MiniBrowser overrides the color chooser, but it happens in Epiphany and any WebView with `<input type="color">`
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
Oh wow, that's bad.
Test page: https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_input_type_color
Michael Catanzaro
> color chooser opens in a dialog outside the window
It does use the parent window so it gets positioned correctly, but it's not modal, which is not what users expect. This cannot be changed using GtkColorChooserDialog because it doesn't expose GtkDialogFlags.
GtkColorChooserDialog is deprecated (because GtkDialog is itself deprecated). The solution will be to switch to GtkColorDialog.
> and closes when moving the mouse pointer
I don't see this. Must have been fixed at some point.
Michael Catanzaro
Pull request: https://github.com/WebKit/WebKit/pull/45170
two
*i later found that it actually closes when receving hold event (that tells that a finger is on the touchpad), not the pointer moving event
it's just that when i moved the pointer, i, well, touched the touchpad to do it
https://wayland.app/protocols/pointer-gestures-unstable-v1#zwp_pointer_gesture_hold_v1:event:begin
so it's not reproducible if you're using a mouse or x11
Michael Catanzaro
I wound up abandoning my pull request because it would break the ability to select a color from the web content.