Bug 259527
Summary: | When using build-jsc on Linux: Can't exec "xcodebuild": No such file or directory | ||
---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
Component: | Tools / Tests | Assignee: | Michael Catanzaro <mcatanzaro> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | ap, mcatanzaro, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Michael Catanzaro
We have a (seemingly harmless) warning that prints when using build-jsc on Linux:
$ build-jsc --jsc-only --debug --cmakeargs='-DENABLE_C_LOOP=ON -DENABLE_JIT=OFF -DENABLE_SAMPLING_PROFILER=OFF'
Can't exec "xcodebuild": No such file or directory at /home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitdirs.pm line 355.
Use of uninitialized value $xcodebuildVersionOutput in pattern match (m//) at /home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitdirs.pm line 356.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
A stack trace would help here - line 355 is in a function that shouldn't be called on Linux at all.
Michael Catanzaro
Stealing the solution to print a stack trace from https://stackoverflow.com/a/13088008/1120203, I found:
Stack Trace:
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitdirs.pm:1253 in function webkitdirs::xcodeVersion
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitperl/BuildSubproject.pm:150 in function webkitdirs::XcodeOptions
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/build-jsc:33 in function (eval)
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/build-jsc:33 in function main::BEGIN
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/build-jsc:33 in function (eval)
I think we can fix this by just moving the calling code into an XCode-specific path.
Michael Catanzaro
Pull request: https://github.com/WebKit/WebKit/pull/16139
EWS
Committed 266384@main (1c1ef14f21ca): <https://commits.webkit.org/266384@main>
Reviewed commits have been landed. Closing PR #16139 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/113035669>