Bug 259312

Summary:	Fix SQLiteDatabase::turnOnIncrementalAutoVacuum()
Product:	WebKit	Reporter:	Ben Nham <nham>
Component:	Website Storage	Assignee:	Ben Nham <nham>
Status:	RESOLVED DUPLICATE
Severity:	Normal	CC:	sihui_liu
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Ben Nham

Reported 2023-07-18 11:14:06 PDT

PulkoMandy from the Haiku port found that turnOnIncrementalAutoVacuum is broken again on trunk due to 258673@main. (It was previously fixed in 241334@main.) The issue is that we need to call lastError() before finalizing the auto_vacuum statement rather than before. Otherwise lastError() returns the return code from the sqlite3_finalize that destroyed the statement rather than the sqlite3_step that enabled auto-vacuum.

Attachments
Add attachment proposed patch, testcase, etc.

Ben Nham

Comment 1 2023-07-18 11:15:31 PDT

*** This bug has been marked as a duplicate of bug 259284 ***

Note You need to log in before you can comment on or make changes to this bug.