Bug 259289
| Summary: | [WebAssembly] wasm-cli.js JetStream2 tests aren't run in test suite | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Asumu Takikawa <asumu> |
| Component: | WebAssembly | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Asumu Takikawa
The `run-jsc-stress-tests` script is intended to run some Wasm JetStream2 tests via the `wasm-cli.js` script.
Right now, it appears that this was unintentionally broken. For example, see the following commandline example:
```
$ time Tools/Scripts/run-jsc-stress-tests --jsc ~/WebKit/WebKitBuild/Release/bin/jsc -c 32 JSTests/wasm.yaml --filter JetStream2
<test printout here>
11/11
real 0m3.649s
user 0m1.583s
sys 0m2.357s
```
This runtime is suspiciously short for running perf tests. If you edit `wasm-cli.js` to replace the `console.log` with `print`
instead of a no-op function, it prints the following instead:
```
wasm.yaml/PerformanceTests/JetStream2/wasm-cli.js.wasm-air: Starting JetStream2
wasm.yaml/PerformanceTests/JetStream2/wasm-cli.js.wasm-air: Running tsf-wasm:
wasm.yaml/PerformanceTests/JetStream2/wasm-cli.js.wasm-air: Error in runCode: ReferenceError: Can't find variable: isD8
```
This shows that the script is broken and exiting before running the tests. There's a simple patch that should make this work again which I'll post later.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Asumu Takikawa
Pull request: https://github.com/WebKit/WebKit/pull/15896
EWS
Committed 266140@main (046a8f31ca73): <https://commits.webkit.org/266140@main>
Reviewed commits have been landed. Closing PR #15896 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/112492880>