Bug 25926

Summary: Clean up DragController
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Clean up DragController
none
Clean up DragController ap: review+

Eric Seidel (no email)
Reported 2009-05-21 06:39:12 PDT
Clean up DragController Looking at DragController this evening to fix a few bugs I was confused by m_document. I'm no longer confused by it now that I've renamed it to m_documentUnderMouse. I also saw copy/paste code involving clearing the selection when moving out of one document and into another. I moved that code into a function called mouseMovedIntoDocument. I also got rid of a couple needless null-checks after confirming via source inspection they were not ever possible.
Attachments
Clean up DragController (13.74 KB, patch)
2009-05-21 06:43 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Clean up DragController (14.62 KB, patch)
2009-05-21 06:47 PDT, Eric Seidel (no email) 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-05-21 06:43:38 PDT
Created attachment 30542 [details] Clean up DragController 3 files changed, 82 insertions(+), 48 deletions(-)
Eric Seidel (no email)
Comment 2 2009-05-21 06:47:00 PDT
Created attachment 30543 [details] Clean up DragController 4 files changed, 86 insertions(+), 51 deletions(-)
Alexey Proskuryakov
Comment 3 2009-05-21 07:00:14 PDT
Comment on attachment 30543 [details] Clean up DragController r=me with some trivial comments over IRC.
Eric Seidel (no email)
Comment 4 2009-05-21 07:05:48 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/page/DragController.cpp M WebCore/page/DragController.h M WebCore/page/mac/DragControllerMac.mm Committed r43968 Hopefully future readers of DragController.cpp will find it easier to understand now. :)
Note You need to log in before you can comment on or make changes to this bug.