Bug 259116
| Summary: | [GLIB] Update env var used to disable using flatpak to build | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick Griffis <pgriffis> |
| Component: | WebKitGTK | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, dpino |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=279261 | ||
Patrick Griffis
This env var is more clear in its purpose. WKDEV_SDK was used by another script but was never an ideal choice.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Patrick Griffis
Pull request: https://github.com/WebKit/WebKit/pull/15748
EWS
Committed 265955@main (c66b20b0eff6): <https://commits.webkit.org/265955@main>
Reviewed commits have been landed. Closing PR #15748 and removing active labels.
Diego Pino
The expression is not entirely correct, since `WEBKIT_BUILD_USE_SYSTEM_LIBRARIES=0` also works.
Perl's `defined` checks whether a variable exists. To make the expression only work when `WEBKIT_BUILD_USE_SYSTEM_LIBRARIES=1`, it's also necessary to check its value is true.
Diego Pino
Re-opening for pull request https://github.com/webkit/webkit/pull/33236
Diego Pino
This follow-up eventually landed via https://github.com/WebKit/WebKit/pull/33237