Bug 25904

Summary:

[Chromium] Mac Chromium HTML selects don't initialize their widths

Product:

WebKit

Reporter:

Paul Godavari <paul>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Fix for PopupListBox width initialization	mjs: review-
Fix for the popup width initialization bug and a manual regression test.	eric: review-
Updated patch with more description of the problem being solved.	eric: review+

Paul Godavari

Reported 2009-05-20 19:10:26 PDT

Mac Chromium HTML selects don't set their widths properly at creation time, leading to occasional hit testing errors (making items unable to be selected).

Attachments
Fix for PopupListBox width initialization (1.34 KB, patch) 2009-05-20 19:22 PDT, Paul Godavari	mjs: review-	Details Formatted Diff Diff
Fix for the popup width initialization bug and a manual regression test. (2.49 KB, patch) 2009-05-28 15:34 PDT, Paul Godavari	eric: review-	Details Formatted Diff Diff
Updated patch with more description of the problem being solved. (3.19 KB, patch) 2009-06-01 14:40 PDT, Paul Godavari	eric: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Paul Godavari

Comment 1 2009-05-20 19:22:06 PDT

Created attachment 30519 [details] Fix for PopupListBox width initialization

Eric Seidel (no email)

Comment 2 2009-05-21 18:05:16 PDT

Comment on attachment 30519 [details] Fix for PopupListBox width initialization No way to test this? We can make hit testing tests from JavaScript quite easily... document.elementAtPoint() will hit test.

Maciej Stachowiak

Comment 3 2009-05-22 00:36:50 PDT

Comment on attachment 30519 [details] Fix for PopupListBox width initialization Please add a regression test and resubmit.

Paul Godavari

Comment 4 2009-05-28 15:34:55 PDT

Created attachment 30758 [details] Fix for the popup width initialization bug and a manual regression test.

Eric Seidel (no email)

Comment 5 2009-06-01 13:51:43 PDT

Comment on attachment 30758 [details] Fix for the popup width initialization bug and a manual regression test. I don't understand what your test is testing. Why does it need 26 options? Ideally the test should have the minimum amount of content to get the point across and no more. Why is document.elementAtPoint() insufficient for this test? I take it the <select> element draws at the right place, but the popup itself (a window over the top of Chromium) does not? In that case, I can see that this would be untestable, but you should explain that in your ChangeLog.

Paul Godavari

Comment 6 2009-06-01 14:40:21 PDT

Created attachment 30841 [details] Updated patch with more description of the problem being solved. Updated the patch as per discussion with Eric.

Eric Seidel (no email)

Comment 7 2009-06-04 16:02:05 PDT

Comment on attachment 30841 [details] Updated patch with more description of the problem being solved. Looks good. Thanks. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/manual-tests/select-narrow-width.html M WebCore/platform/chromium/PopupMenuChromium.cpp Committed r44438

Note You need to log in before you can comment on or make changes to this bug.