| Summary: | [Chromium] Mac Chromium HTML selects don't initialize their widths | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Paul Godavari <paul> | ||||||||
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dglazkov | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Mac | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Paul Godavari
2009-05-20 19:10:26 PDT
Created attachment 30519 [details]
Fix for PopupListBox width initialization
Comment on attachment 30519 [details]
Fix for PopupListBox width initialization
No way to test this? We can make hit testing tests from JavaScript quite easily...
document.elementAtPoint()
will hit test.
Comment on attachment 30519 [details]
Fix for PopupListBox width initialization
Please add a regression test and resubmit.
Created attachment 30758 [details]
Fix for the popup width initialization bug and a manual regression test.
Comment on attachment 30758 [details]
Fix for the popup width initialization bug and a manual regression test.
I don't understand what your test is testing. Why does it need 26 options? Ideally the test should have the minimum amount of content to get the point across and no more.
Why is document.elementAtPoint() insufficient for this test? I take it the <select> element draws at the right place, but the popup itself (a window over the top of Chromium) does not? In that case, I can see that this would be untestable, but you should explain that in your ChangeLog.
Created attachment 30841 [details]
Updated patch with more description of the problem being solved.
Updated the patch as per discussion with Eric.
Comment on attachment 30841 [details] Updated patch with more description of the problem being solved. Looks good. Thanks. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/manual-tests/select-narrow-width.html M WebCore/platform/chromium/PopupMenuChromium.cpp Committed r44438 |