Bug 259010
| Summary: | Add comment about duplicate check in 'checkInvalidControlsAndCollectUnhandled' function within 'if' clause | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Forms | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Bug to remove duplicate check from this:
https://github.com/WebKit/WebKit/blob/da535631d69cc22753758c77b058981ee8bb3e09/Source/WebCore/html/HTMLFormElement.cpp#L811
We have:
if (control->form() == this && !control->checkValidity(&unhandledInvalidControls) && control->form() == this)
Which can be just:
if (!control->checkValidity(&unhandledInvalidControls) && control->form() == this)
______
Just raising to fix this.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
This is needed for: fast/forms/interactive-validation-remove-node-in-handler.html & fast/forms/checkValidity-handler-updates-dom.html
Ahmad Saleem
Reopening to add explanatory comment.
EWS
Committed 265890@main (e7780d735de3): <https://commits.webkit.org/265890@main>
Reviewed commits have been landed. Closing PR #15663 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/111982031>