Bug 258776
| Summary: | Improve the reliability and accuracy of SVG getTotalLength | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across following commit:
Commit: https://chromium.googlesource.com/chromium/blink/+/4767de54b0b1487746440fc3a44ff47e4f8bb671
It has test, which we fail, if we run as is (it needs to run via 'run-webkit-tests)' because otherwise, we even fail with JSFiddle in the patched browser (while using MiniBrowser). Only Chrome Canary 117 is passing them in JSFiddle.
I had to revert following: https://github.com/WebKit/WebKit/commit/2203914678e5a8b23334dd5e4d221076eacda995
At least locally (at my skill level) - there might be better way to fix this.
Although after reverting and applying Blink's patch and running 'path-getTotalLength-hang.html' test with --debug flag, we don't crash / fail the test though value is slightly changed.
So I think we can revert other patch and apply Blink's patch and get more wins or if someone else can take it and do it better way. Happy to leave it to others to comment.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/111962327>
Ahmad Saleem
PR Attempt - https://github.com/WebKit/WebKit/pull/17308
Some test failures.