Bug 258734
| Summary: | REGRESSION(265569@main): All path segments should be coded by StreamConnectionEncoder | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Layout and Rendering | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=255898 https://bugs.webkit.org/show_bug.cgi?id=258762 |
||
Said Abou-Hallawa
After 265569@main, the composite path segments, such as PathDataLine, became decodable by IPC coders only. We need to add StreamConnectionEncoder as additional coder for encoding and decoding them. The reason for this change in 265569@main, was the serialization.in files do not know hot to deal with template struct/class. These composite path segments are defined as templates for two types. So the encoding/decoding code was implemented in WebCoreArgumentCoders.h. This caused a perf regression in MotionMark CanvasLines subtest.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/111570644>
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/15451
EWS
Committed 265680@main (7dc4e7c7d38b): <https://commits.webkit.org/265680@main>
Reviewed commits have been landed. Closing PR #15451 and removing active labels.