Bug 258673

Summary:	GraphicsContextState returns it has inline changes when it does not have any change
Product:	WebKit	Reporter:	Said Abou-Hallawa <sabouhallawa>
Component:	Layout and Rendering	Assignee:	Said Abou-Hallawa <sabouhallawa>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=255898

Said Abou-Hallawa

Reported 2023-06-29 08:09:19 PDT

GraphicsContextState::containsOnlyInlineChanges() and GraphicsContextState::containsOnlyInlineStrokeChanges() should return false when the m_changeFlags is empty.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-06-29 08:09:37 PDT

<rdar://problem/111513820>

Said Abou-Hallawa

Comment 2 2023-06-29 08:19:02 PDT

Pull request: https://github.com/WebKit/WebKit/pull/15407

Said Abou-Hallawa

Comment 3 2023-06-29 13:05:00 PDT

These two functions were return true for the empty case which is wrong. This makes Recorder::strokePath() call recordStrokeLineWithColorAndThickness() more often which causes more IPC bytes to be sent to GPUP. It also causes unnecessary DisplayList items to be handled by RemoteDisplayListRecorder::strokeLineWithColorAndThickness().

EWS

Comment 4 2023-06-29 13:16:57 PDT

Committed 265627@main (3f9ec4370045): <https://commits.webkit.org/265627@main> Reviewed commits have been landed. Closing PR #15407 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.