Bug 25861 – Remove http/tests/cookies/simple-cookies-expired.html from skip list after CFNetwork issue is resolved

• Component: Tools / Tests
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

* SUMMARY
One of the tests added for Bug 24569 fails inexplicably on Windows:

LayoutTests/http/tests/cookies/simple-cookies-expired.html

It was added to the Skipped list to keep the buildbot green.

[Mark Rowe (bdash)]

<rdar://problem/6901322>

[Alice Liu]

Has this test ever worked on windows?  wasn't it just added yesterday? 

[David Kilzer (:ddkilzer)]

(In reply to comment #2)
> Has this test ever worked on windows?  wasn't it just added yesterday? 

Not sure if it ever worked on Windows at some point...only tested via the buildbot.

The test was added only yesterday, but passes on Tiger and Leopard which indicates a bug in CFNetwork for Windows.

http://trac.webkit.org/browser/trunk/LayoutTests/http/tests/cookies/simple-cookies-expired.html
http://trac.webkit.org/browser/trunk/LayoutTests/http/tests/cookies/resources/simple-cookies-expired.js

I suppose the cookie might not be set if the total time to set the date and load the XMLHTTPRequest were more than 1 minute, but that seems unlikely (especially on Release builds).

http://build.webkit.org/results/Windows%20Release%20(Tests)/r43852%20(1012)/results.html
http://build.webkit.org/results/Windows%20Debug%20(Tests)/r43852%20(1128)/results.html

[Julien Chaffraix]

(In reply to comment #3)
> (In reply to comment #2)
> > Has this test ever worked on windows?  wasn't it just added yesterday? 
> 
> Not sure if it ever worked on Windows at some point...only tested via the
> buildbot.

My apologies, I completely forgot to reply to this bug. I haven't set up a Windows machine so the patch was not tested on Windows: it was only tested on Mac Leopard and Linux Qt (maybe also Gtk but I am not sure).

[David Kilzer (:ddkilzer)]

Created attachment 51325 [details]
Patch v1

[David Kilzer (:ddkilzer)]

Comment on attachment 51325 [details]
Patch v1

Letting the commit queue land this; it should fail if the test fails.

[WebKit Commit Bot]

Comment on attachment 51325 [details]
Patch v1

Clearing flags on attachment: 51325

Committed r56379: <http://trac.webkit.org/changeset/56379>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[David Kilzer (:ddkilzer)]

(In reply to comment #8)
> All reviewed patches have been landed.  Closing bug.

This test hasn't shown up as failing on build.webkit.org either.

[Eric Seidel (no email)]

http/tests/cookies/simple-cookies-expired.html is flaky.  Filing bug now.