Bug 258509
| Summary: | [Curl] Coding style issue in ResourceResponse.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kenji Shukuwa <kenji.shukuwa> |
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | fujii.hironori, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Kenji Shukuwa
ERROR: Source/WebCore/platform/network/curl/ResourceResponse.h:63: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kenji Shukuwa
Removing WEBCORE_EXPORT from a class means adding WEBCORE_EXPORT to many functions.
However, if you remove the functions that hide status code checks such as isMovedPermanently and write the status code directly in the code like other ports, they will be unnecessary.
I would like to refer to the SOUP port and modify the code.
Kenji Shukuwa
Pull request: https://github.com/WebKit/WebKit/pull/15287
EWS
Committed 265537@main (593b1ac94072): <https://commits.webkit.org/265537@main>
Reviewed commits have been landed. Closing PR #15287 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/111368722>