Bug 258409
| Summary: | Skip JIT memory allocation in ExecutableAllocator::disableJIT() when running on an open source XNU. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | commit-queue, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 258435 | ||
| Bug Blocks: | |||
Mark Lam
The open source XNU does not support special handling of JIT memory. However, macOS Safari and WebKit binaries still need to be able to run on the open source XNU, albeit without JIT.
However, ExecutableAllocator::disableJIT() is still trying to allocated JIT memory if the JIT entitlement is present (which is defined by the WebKit binary, not the kernel), and currently, will assert that the allocation succeeds. We need to skip this allocation and assertion when running on open source XNU because the allocation is not necessary, and the assertion is invalid for the open source kernel and will fail every time.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mark Lam
rdar://111170164
Mark Lam
Pull request: https://github.com/WebKit/WebKit/pull/15204
EWS
Committed 265435@main (6063bc484b4f): <https://commits.webkit.org/265435@main>
Reviewed commits have been landed. Closing PR #15204 and removing active labels.
WebKit Commit Bot
Re-opened since this is blocked by bug 258435
Mark Lam
Pull request: https://github.com/WebKit/WebKit/pull/15226
EWS
Committed 265446@main (ee19c59a58e7): <https://commits.webkit.org/265446@main>
Reviewed commits have been landed. Closing PR #15226 and removing active labels.