Summary: | Make ChromeClient only have pure virtuals | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Holger Freyther <zecke> | ||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Holger Freyther
2009-05-16 03:35:07 PDT
Created attachment 30411 [details]
Make recent additions pure virtual again
Make setCursor, scrollRectIntoView, requestGeolocationPermissionForFrame pure virtual.
Comment on attachment 30411 [details] Make recent additions pure virtual again > - virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const {} // Platforms other than Mac can implement this if it ever becomes necessary for them to do so. > + virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const = 0; // Platforms other than Mac can implement this if it ever becomes necessary for them to do so. I don't think the comment makes sense any more if this is a pure virtual. This change seems OK. This is the reason I used pure virtuals in the first place, but I'm not entirely sure either way whether this is a good thing or not. r=me |