Bug 258249

Summary: [FFC] FlexLayout::computeAvailableMainAndCrossSpace should follow spec language
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 258235    
Attachments:
Description Flags
Patch
none
[fast-cq]Patch ews-feeder: commit-queue-

zalan
Reported 2023-06-17 10:16:37 PDT
ssia
Attachments
Patch (2.50 KB, patch)
2023-06-17 10:19 PDT, zalan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (2.44 KB, patch)
2023-06-19 08:26 PDT, zalan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2023-06-17 10:19:08 PDT
Created attachment 466737 [details] Patch
Antti Koivisto
Comment 2 2023-06-18 11:31:52 PDT
Comment on attachment 466737 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=466737&action=review > Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:131 > + auto computeFinalSize = [&](auto& candidateSizes, auto& finalSize) { wouldn't it be cleaner to just return the finalSize?
zalan
Comment 3 2023-06-19 08:26:52 PDT
Created attachment 466760 [details] [fast-cq]Patch
zalan
Comment 4 2023-06-19 08:27:12 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 466737 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=466737&action=review > > > Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:131 > > + auto computeFinalSize = [&](auto& candidateSizes, auto& finalSize) { > > wouldn't it be cleaner to just return the finalSize? yeah, not sure what happened here.
EWS
Comment 5 2023-06-19 10:47:52 PDT
Committed 265308@main (521acb6278c9): <https://commits.webkit.org/265308@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 466760 [details].
Radar WebKit Bug Importer
Comment 6 2023-06-19 10:48:16 PDT
<rdar://problem/111006977>
Note You need to log in before you can comment on or make changes to this bug.