Summary: | REGRESSION(264798@main): Archive-minified-built-product is failing due to extra argument "archive" | ||
---|---|---|---|
Product: | WebKit | Reporter: | Robert Jenner <jenner> |
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | aakash_jain, clopez, gsnedders, webkit-bot-watchers-bugzilla, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=256283 |
Description
Robert Jenner
2023-06-13 11:54:39 PDT
Command from old successful run: https://build.webkit.org/#/builders/706/builds/7007/steps/13/logs/stdio python3 Tools/CISupport/built-product-archive --platform=mac-ventura --release archive --minify Command from recent failing run: https://build.webkit.org/#/builders/706/builds/7107/steps/13/logs/stdio python3 Tools/CISupport/built-product-archive --platform=mac-ventura --release archive --minify archive There is extra argument 'archive'. This seems to be regression from https://commits.webkit.org/264798@main This change (264798@main) changed ArchiveBuiltProduct but not its subclass ArchiveMinifiedBuiltProduct, leaving the subclass both with its existing "archive" and the one added in ArchiveBuiltProduct.run (https://github.com/WebKit/WebKit/blob/964948660ae097f883e12408b84dea3efd98a7ae/Tools/CISupport/build-webkit-org/steps.py#L434). It's not clear to me why it needs to be added in ArchiveBuiltProduct.run at all? Python's optparse doesn't care if arguments and options are intermixed, so there's no need for the run method to add it explicitly to the end as far as I can see? Pull request: https://github.com/WebKit/WebKit/pull/14931 Committed 265131@main (328332879f73): <https://commits.webkit.org/265131@main> Reviewed commits have been landed. Closing PR #14931 and removing active labels. |