Bug 257992

Summary: text-decoration-thickness not properly propagated to inner spans with non-inline style
Product: WebKit Reporter: Jon Lee <jonlee554>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: ahmad.saleem792, karlcow, kizmarh, koivisto, mmaxfield, ntim, webkit-bug-importer
Priority: P2 Keywords: BrowserCompat, InRadar
Version: Safari 16   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=250831
https://bugs.webkit.org/show_bug.cgi?id=264245
https://bugs.webkit.org/show_bug.cgi?id=282027
Attachments:
Description Flags
rendering in safari, firefox, chrome none

Jon Lee
Reported 2023-06-12 17:32:34 PDT
https://codepen.io/legion80/pen/YzRyqJO compare with Chrome and Firefox. The structure is <a><span></span></a> with CSS text-decoration-thickness set. If the span is inline, the style is propagated. If the style is inline-block, the decoration is removed (consistent across all browsers). If the style is block, the style is not propagated in Safari, but is propagated in Chrome and Firefox.
Attachments
rendering in safari, firefox, chrome (1.24 MB, image/png)
2024-11-10 22:21 PST, Karl Dubost 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-06-19 17:33:16 PDT
<rdar://problem/111015539>
Ahmad Saleem
Comment 2 2023-06-22 15:01:43 PDT
https://github.com/WebKit/WebKit/blob/6172ecd8b1485a5387d034f7e623a36b8f5a45fc/Source/WebCore/style/StyleAdjuster.cpp#L187 by adding ‘DisplayType::Block’? ^ Something here to also inherit text decoration effects?
Tim Nguyen (:ntim)
Comment 3 2023-11-13 01:21:26 PST
Very likely same regression range as bug 250831
Karl Dubost
Comment 4 2024-11-10 22:21:09 PST
Created attachment 473189 [details] rendering in safari, firefox, chrome Apart of the last one, this is consitent. https://codepen.io/legion80/pen/YzRyqJO This is the one failing. <style>a.thick { text-decoration-thickness: 3px; }</style> <a href="#" class="thick"><span style="display:block">- link text inside span styled block</span></a>
Note You need to log in before you can comment on or make changes to this bug.