Bug 25795
| Summary: | Refactor V8 setters to eliminate common setter code | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Andrew Wilson <atwilson> |
| Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Minor | CC: | andersca, arv |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Andrew Wilson
There's quite a bit of common code in the V8 bindings - functions like ACCESSOR_SETTER(WorkerOnmessage) and ACCESSOR_SETTER(MessagePortClose) are nearly identical (the getters are very similar as well).
We should refactor the common code into static utility functions that the various classes can share.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Anders Carlsson
V8 is gone from WebKit.