Bug 257905
| Summary: | [GLib] Process launching hangs if xdg-dbus-proxy is not installed | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Michael Catanzaro
In https://gitlab.gnome.org/GNOME/gnome-build-meta/-/issues/685 we discovered that process launching hangs if xdg-dbus-proxy is not installed. This is because we do a synchronous read() at the bottom of XDGDBusProxy::launch, and it never completes if spawning bwrap failed.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
Current behavior is we print the following and then hang forever:
bwrap: execvp /usr/bin/foo: No such file or directory
Proposed behavior is to print then crash (because this is not recoverable):
bwrap: execvp /usr/bin/foo: No such file or directory
** (epiphany:203869): ERROR **: 15:49:53.627: Failed to fully launch dbus-proxy: Child process exited with code 1
Trace/breakpoint trap (core dumped)
Michael Catanzaro
Pull request: https://github.com/WebKit/WebKit/pull/14825
EWS
Committed 267038@main (971943d9b665): <https://commits.webkit.org/267038@main>
Reviewed commits have been landed. Closing PR #14825 and removing active labels.