Bug 25787

Summary:

[GTK] Update NetscapeTest Plugin

Product:

WebKit

Reporter:

Holger Freyther <zecke>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Gtk

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Properly unregister the plugin instance	none
Merge r39877	jmalonzo: review+
Log through JavaScript Console (r41819)	jmalonzo: review+

Holger Freyther

Reported 2009-05-14 04:46:02 PDT

For Gtk+ main.cpp of the TestNetscapePlugin plugin was forked (to not interfere with mac), merge the changes from main.cpp back to the Gtk+ version.

Attachments
Properly unregister the plugin instance (1.87 KB, patch) 2009-05-14 04:47 PDT, Holger Freyther	no flags	Details Formatted Diff Diff
Merge r39877 (3.13 KB, patch) 2009-05-14 04:48 PDT, Holger Freyther	jmalonzo: review+	Details Formatted Diff Diff
Log through JavaScript Console (r41819) (5.43 KB, patch) 2009-05-14 04:50 PDT, Holger Freyther	jmalonzo: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Holger Freyther

Comment 1 2009-05-14 04:47:09 PDT

Created attachment 30329 [details] Properly unregister the plugin instance Copied from a recent Qt bugfix.

Holger Freyther

Comment 2 2009-05-14 04:48:49 PDT

Created attachment 30330 [details] Merge r39877 Merge r39877 and log through the JavaScript Console.

Holger Freyther

Comment 3 2009-05-14 04:49:53 PDT

Comment on attachment 30330 [details] Merge r39877 Wrong patch. Invoke testNPRuntime and remove the test from the skipped list.

Holger Freyther

Comment 4 2009-05-14 04:50:40 PDT

Created attachment 30331 [details] Log through JavaScript Console (r41819) Merge r41819 and log through the javascript console.

Holger Freyther

Comment 5 2009-05-14 07:28:17 PDT

Comment on attachment 30329 [details] Properly unregister the plugin instance Clearing review, landed in r43697.

Jan Alonzo

Comment 6 2009-05-15 06:30:30 PDT

Comment on attachment 30331 [details] Log through JavaScript Console (r41819) Please give a brief summary of why we're not using printf in this case prior to landing this - thanks. r=me.

Jan Alonzo

Comment 7 2009-05-15 06:36:54 PDT

Comment on attachment 30330 [details] Merge r39877 r=me.

Holger Freyther

Comment 8 2009-05-15 22:46:12 PDT

(In reply to comment #6) > (From update of attachment 30331 [details] [review]) > Please give a brief summary of why we're not using printf in this case prior to > landing this - thanks. The only reference in r41819 is a radar bug. The reason for us to follow is two fold. First of all the -expected result has a "CONSOLE MESSAGE: line 0: PLUGIN:" the second is we might run the plugin in a different process and then the stdout's might not be the same, in this case we still want the output to come from the DRT process.

Holger Freyther

Comment 9 2009-05-16 02:11:43 PDT

Landed in r43800 and r43801.

Note You need to log in before you can comment on or make changes to this bug.