Bug 257730
| Summary: | [WPT import friction] import-w3c-tests should not rely on the web-platform-tests directory name | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | annevk, jbedard, karlcow, marcosc, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Sneddon [:gsnedders]
Currently if you specify `--src-dir` then the web-platform-tests checkout has to be in a directory called "web-platform-tests" within that source directory.
Given the repository is now https://github.com/web-platform-tests/wpt.git, `git clone https://github.com/web-platform-tests/wpt.git` results in the directory being called "wpt".
Especially when we no longer import any other W3C test suite, this becomes a nuisance.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/110278828>
Sam Sneddon [:gsnedders]
*** Bug 274824 has been marked as a duplicate of this bug. ***
Sam Sneddon [:gsnedders]
*** Bug 277277 has been marked as a duplicate of this bug. ***
Sam Sneddon [:gsnedders]
*** Bug 293814 has been marked as a duplicate of this bug. ***
Sam Sneddon [:gsnedders]
Now we only support `web-platform-tests` as a source repo (since https://commits.webkit.org/270006@main), we can probably be smarter about this — though there's still a lot of places in the code that assume the import destination is `imported/w3c`.
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/49436
EWS
Committed 298861@main (a5576777af89): <https://commits.webkit.org/298861@main>
Reviewed commits have been landed. Closing PR #49436 and removing active labels.