Bug 257485
| Summary: | REGRESSION(262844@main): svg/dynamic-updates/SVGFE* tests no longer react on changes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> |
| Component: | SVG | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, heycam, sabouhallawa, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=255258 | ||
Nikolas Zimmermann
Back in February, svg/dynamic-updates/SVGFE* tests were still working properly - in ToT they no longer show any visual update. Investigate.
Mark them as 'ImageOnlyFailure' in the test expectations for now.
As said before, these tests should really be reftests -- we cannot detect these kind of issues in EWS & co, since these tests all rely on pixel testing, which is not run by default on the bots.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Nikolas Zimmermann
Pull request: https://github.com/WebKit/WebKit/pull/14482
EWS
Committed 264674@main (03d330e0fe9b): <https://commits.webkit.org/264674@main>
Reviewed commits have been landed. Closing PR #14482 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/110005491>
Nikolas Zimmermann
They were only marked as failures in the expectations -- the bug is not fixed yet, reopening.
Cameron McCormack (:heycam)
Caused by https://bugs.webkit.org/show_bug.cgi?id=255258.
Chris Dumez
I caused this, I can investigate and fix.
Chris Dumez
I have been opening a few of these tests in the browser with a spade before my change and trunk and don't see much difference. How can I tell the tests are failing?
Chris Dumez
Maybe not all the tests that were skipped are truly failing. I found LayoutTests/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr.html that is definitely failing though.
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/14550
EWS
Committed 264763@main (d91dd403c67e): <https://commits.webkit.org/264763@main>
Reviewed commits have been landed. Closing PR #14550 and removing active labels.