Bug 257464
| Summary: | release 2.40.2 fails to build with bubblewrap disabled | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Jacoutot <ajacoutot> |
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Major | ||
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | Other | ||
Antoine Jacoutot
Hi.
The commit https://github.com/WebKit/WebKit/commit/4c39f38757287198c49091ee12fc548cc9c212d6 implied that BWRAP_EXECUTABLE is always defined.
However, when building with BUBBLEWRAP_SANDBOX=Off, Source/cmake/BubblewrapSandboxChecks.cmake is not used and hence BWRAP_EXECUTABLE is not set.
/usr/ports/pobj/webkitgtk41-2.40.2-webkitgtk41/webkitgtk-2.40.2/Source/WTF/wtf/glib/Sandbox.cpp:49:13: error: use of undeclared identifier 'BWRAP_EXECUTABLE'
BWRAP_EXECUTABLE,
^
1 error generated.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Antoine Jacoutot
Fixed with commit https://github.com/WebKit/WebKit/commit/4977290ab4ab35258a6da9b13795c9b0f7894bf4