insertItemBefore boundary condition incorrect

• Component: SVG
• Status: RESOLVED FIXED

[Adam Barth]

When we get an out-of-bound index here:

http://trac.webkit.org/browser/trunk/WebCore/svg/SVGList.h#L99

we should append instead of throwing an error according to the spec:

http://www.w3.org/TR/SVG/types.html

[Adam Barth]

I have a patch that I can upload when I get home.

[Adam Barth]

Created attachment 30262 [details]
patch (no tests)

Turns out unhorking my build was too much for Mac Mini to handle tonight.  Here's the code part of the patch.  I still need to update the tests.

[Adam Barth]

Created attachment 30405 [details]
patch

patch!

[Adam Barth]

Comment on attachment 30405 [details]
patch

No, that't not right.

[Adam Barth]

Created attachment 30406 [details]
better patch

That's better.

[Oliver Hunt]

Comment on attachment 30406 [details]
better patch

r=me, but i'd prefer it if the test were updated to actually confirm the correct insertion order

[Adam Barth]

(In reply to comment #6)
> (From update of attachment 30406 [details] [review])
> r=me, but i'd prefer it if the test were updated to actually confirm the
> correct insertion order

You mean add the shouldBes after each modification?

[Oliver Hunt]

(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 30406 [details] [review] [review])
> > r=me, but i'd prefer it if the test were updated to actually confirm the
> > correct insertion order
> 
> You mean add the shouldBes after each modification?
> 
Yeah -- i find myself wondering what inserting null is meant to do? (and we;ll probably want to insert distinguishable values)

[Adam Barth]

Created attachment 30407 [details]
even better patch?

Like the new svglist-insertBeforeItem-appends test?

[Oliver Hunt]

Comment on attachment 30407 [details]
even better patch?

r=me

[Adam Barth]

Sending        LayoutTests/ChangeLog
Sending        LayoutTests/svg/dom/svglist-exception-on-out-bounds-error-expected.txt
Sending        LayoutTests/svg/dom/svglist-exception-on-out-bounds-error.html
Adding         LayoutTests/svg/dom/svglist-insertItemBefore-appends-expected.txt
Adding         LayoutTests/svg/dom/svglist-insertItemBefore-appends.html
Sending        WebCore/ChangeLog
Sending        WebCore/svg/SVGList.h
Transmitting file data .......
Committed revision 43795.