Summary: | ASSERTION FAILED: rootRenderer.isDocumentElementRenderer() for fast/body-propagation/background-image/007-xhtml.xhtml | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Fujii Hironori
2023-05-24 13:51:51 PDT
WinCairo-64-bit-Debug-Tests is constantly failing. https://build.webkit.org/results/WinCairo-64-bit-Debug-Tests/264434@main%20(20315)/results.html 264434@main: first bad 264419@main: last good This code is assuming the parent of <body> is <html>. But, it's <bogus> in the tests. I think we should copy the following code from RenderElement::styleWillChange. https://github.com/WebKit/WebKit/blob/48c6a9eda4fdc93834a69222bd4db466c7b94e52/Source/WebCore/rendering/RenderElement.cpp#L882 > bool drawsRootBackground = isDocumentElementRenderer() || (isBody() && !rendererHasBackground(document().documentElement()->renderer())); Created attachment 466485 [details]
test case
WinCairo Debug MiniBrowser can crash just by loading this test case.
Mac Debug MiniBrowser also can crash for the test case (attachment#466485 [details]). But, it needs some reloading.
You are right, https://trac.webkit.org/changeset/179145/webkit made some incorrect assumption on the <body>'s parent. Will fix. Thank you! Created attachment 466492 [details]
Patch
Created attachment 466493 [details]
Patch
Committed 264535@main (7e2da0a4cfeb): <https://commits.webkit.org/264535@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 466493 [details]. |