Bug 257269
| Summary: | Speedometer 3 hits Webkit's replaceState/pushState limits | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | History | Assignee: | Ryosuke Niwa <rniwa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | achristensen, annevk, beidson, cdumez, ggaren, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Speedometer 3 being developed at https://github.com/WebKit/Speedometer is hitting WebKit's 30s limit for replaceState/pushState.
Do we really need to limit this at 100 in 30s? Or can the limit be higher like 1000 in 30s?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Geoffrey Garen
I believe the goal of this limit was to avoid DoS of the UI process, which might include client app behaviors outside WebKit's control, when updating history data structures and UI. As long as a test case for 1000 / 30s, where the payload is the maximum size, does not cause serious responsiveness issues in WebKit browsers, upping the limit is probably fine.
Ryosuke Niwa
It seems mildly problematic to have this limit only in WebKit. It can lead to WebKit-only bugs / failures.
Ryosuke Niwa
Pull request: https://github.com/WebKit/WebKit/pull/14301
EWS
Committed 264499@main (451d10e21bf9): <https://commits.webkit.org/264499@main>
Reviewed commits have been landed. Closing PR #14301 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/109806715>