Bug 256828
| Summary: | Notifications API: default silent to platform convention | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Marcos Caceres <marcosc> |
| Component: | WebCore Misc. | Assignee: | Marcos Caceres <marcosc> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Marcos Caceres
The NotificationOptions dictionary specifies boolean silent=false; by default.
That default can conflict with certain platforms/OSs, whereby if a notification is silent (or not) should really be left up to OS.
Spec change:
https://github.com/whatwg/notifications/pull/194
The proposal makes the silent member on the NotificationOption dictionary default to null. This is then reflected by the silent attribute of the Notification interface.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/109390045>
Marcos Caceres
Pull request: https://github.com/WebKit/WebKit/pull/13912
EWS
Committed 264397@main (bb5a5fbce2e9): <https://commits.webkit.org/264397@main>
Reviewed commits have been landed. Closing PR #13912 and removing active labels.